Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Stock difference between gl entry and stock ledger entry booked in stock adjustment #15374

Merged
merged 1 commit into from Oct 3, 2018

Conversation

rohitwaghchaure
Copy link
Collaborator

No description provided.

@stale
Copy link

stale bot commented Sep 20, 2018

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale
Copy link

stale bot commented Oct 1, 2018

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Oct 1, 2018
* flt(item.qty) * flt(item.conversion_factor), item.precision("base_net_amount"))
* flt(item.qty) * flt(item.conversion_factor), net_amt_precision)

# Stock ledger value is not matching with the warehouse amount
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

move this to a separate function. Average function size should be 10 lines

@rmehta rmehta merged commit a5576f5 into frappe:hotfix Oct 3, 2018
@schilgod
Copy link
Contributor

@rohitwaghchaure @rmehta Possible to provide some explain why this change was necessary? We are having issues with PI having COGS entries, we cant figure out why COGS was credited with the difference amount. thanks.

@lxnow
Copy link

lxnow commented Mar 7, 2021

I'd like to understand too, particularly in the Purchase receipt level generating COGS entries

@A7medAbdin
Copy link

A7medAbdin commented Apr 17, 2024

The same here too, is there is any update

@github-actions github-actions bot locked as resolved and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants