Lead notes #15510
Merged
Lead notes #15510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
This PR follows the discussion in issue #15508.
A field for adding notes regarding a lead is obviously missing in the lead doctype.
We can use comments, but comments are more time-related, whereas most of the time one need to register general notes regarding a lead that should be kept in one place.
Our proposal is therefore to add a new collapsible section in the Lead called "Notes":
This section will have a text editor, thus allowing any sales person to make a formatted note regarding a lead.
I have also updated the sales details report to add this field:
(Maybe it would be good to have the possibility to make the text wrappable in a future update of the datatable)
When exporting in PDF, the format is kept as defined (this test example is extreme):
Thanks in advance for your review and feedback.
Technical note
I have moved the report from the "Selling" module to the "CRM" module for consistency, because the Lead doctype is in the CRM module.