Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Naming Series Form Parsing Fix #15514

Merged
merged 1 commit into from Sep 27, 2018

Conversation

SaiFi0102
Copy link
Collaborator

When updating naming series starting number the parsing function deleted the last part of the string with the assumption that it would be a '#####'. This led to a problem that it would parse the naming series incorrectly so that the last part '-' would be removed:
image

This pull request removes the '#####' part only if it is actually a '#####' part

@nabinhait nabinhait changed the base branch from develop to staging-fixes September 27, 2018 10:12
@nabinhait nabinhait merged commit c2dd9ab into frappe:staging-fixes Sep 27, 2018
@SaiFi0102 SaiFi0102 deleted the Naming-Series-Parse-Fix branch September 29, 2018 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants