Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Add provision for prebilled subscription invoices #15700

Merged
merged 1 commit into from
Oct 16, 2018
Merged

feat: Add provision for prebilled subscription invoices #15700

merged 1 commit into from
Oct 16, 2018

Conversation

joeirimpan
Copy link
Contributor

(cherry picked from commit db33e63)

Discussion: #15571
Prev PR: #15572

@joeirimpan joeirimpan mentioned this pull request Oct 16, 2018
Closed
@rohitwaghchaure rohitwaghchaure self-assigned this Oct 16, 2018
@rohitwaghchaure rohitwaghchaure merged commit 19be730 into frappe:staging-fixes Oct 16, 2018
@barredterra
Copy link
Collaborator

barredterra commented Feb 3, 2022 •
edited

Hey @joeirimpan, what are is_postpaid_to_invoice() and is_prepaid_to_invoice() supposed to do? They're causing much trouble for me, because in this case (#29626) both methods return False at the same time, breaking the subscription.

Why is is_postpaid_to_invoice not the opposite of is_prepaid_to_invoice?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@rohitwaghchaure rohitwaghchaure

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@joeirimpan @barredterra @rohitwaghchaure