Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[New Feature]Scan Item Barcode label to quick create/update records in items child table #15731

Merged
merged 17 commits into from Nov 13, 2018

Conversation

Zlash65
Copy link
Contributor

@Zlash65 Zlash65 commented Oct 18, 2018

#15329

Scan Barcode field added in

  • Material Request
  • Purchase Order
  • Sales Order
  • Delivery Note
  • Stock Entry
  • Purchase Invoice
  • Sales Invoice

Code cleaned up.

@stale
Copy link

stale bot commented Nov 4, 2018

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Nov 4, 2018
@stale stale bot removed the inactive label Nov 8, 2018
rmehta
rmehta previously requested changes Nov 8, 2018
erpnext/public/js/controllers/transaction.js Outdated Show resolved Hide resolved
@@ -640,7 +640,7 @@ def get_item_details(self, args=None, for_update=False):
'item_name' : item.item_name,
'expense_account' : args.get("expense_account"),
'cost_center' : get_default_cost_center(args, item, item_group_defaults),
'qty' : 0,
'qty' : args.get("qty"),
'transfer_qty' : 0,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

transfer_qty should be set as well

erpnext/selling/page/point_of_sale/point_of_sale.py Outdated Show resolved Hide resolved
@nabinhait nabinhait merged commit 6922415 into frappe:staging-fixes Nov 13, 2018
@PawanMeh
Copy link
Contributor

Some possible gaps, scan field not available on Purchase receipt and also does the scanned bar code get updated in inventory?

@lalnco
Copy link

lalnco commented Jan 4, 2019

@Zlash65 Zarrar, this PR merged only created field to capture Barcode number at the Item level and related docs.

Could you share a gif Screencast of how this will work for multiple items and the item table gets created automatically with scan. If this works like retail stores, it would be a great functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants