fix(tests): Save batch instead of submitting it #17636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ref: https://travis-ci.com/frappe/erpnext/jobs/195859880
Made to develop at #17637.
====================================================================== ERROR: test_get_batch_qty (erpnext.stock.doctype.batch.test_batch.TestBatch) Test getting batch quantities by batch_numbers, item_code or warehouse ====================================================================== Traceback (most recent call last): File "/home/travis/frappe-bench/apps/erpnext/erpnext/stock/doctype/batch/test_batch.py", line 167, in test_get_batch_qty self.make_new_batch_and_entry('ITEM-BATCH-2', 'batch a', '_Test Warehouse - _TC') File "/home/travis/frappe-bench/apps/erpnext/erpnext/stock/doctype/batch/test_batch.py", line 206, in make_new_batch_and_entry stock_entry.submit() File "/home/travis/frappe-bench/apps/frappe/frappe/model/document.py", line 852, in submit self._submit() File "/home/travis/frappe-bench/apps/frappe/frappe/model/document.py", line 841, in _submit self.save() File "/home/travis/frappe-bench/apps/frappe/frappe/model/document.py", line 266, in save return self._save(*args, **kwargs) File "/home/travis/frappe-bench/apps/frappe/frappe/model/document.py", line 319, in _save self.run_post_save_methods() File "/home/travis/frappe-bench/apps/frappe/frappe/model/document.py", line 915, in run_post_save_methods self.run_method("on_submit") File "/home/travis/frappe-bench/apps/frappe/frappe/model/document.py", line 781, in run_method out = Document.hook(fn)(self, *args, **kwargs) File "/home/travis/frappe-bench/apps/frappe/frappe/model/document.py", line 1051, in composer return composed(self, method, *args, **kwargs) File "/home/travis/frappe-bench/apps/frappe/frappe/model/document.py", line 1034, in runner add_to_return_value(self, fn(self, *args, **kwargs)) File "/home/travis/frappe-bench/apps/frappe/frappe/model/document.py", line 775, in <lambda> fn = lambda self, *args, **kwargs: getattr(self, method)(*args, **kwargs) File "/home/travis/frappe-bench/apps/erpnext/erpnext/stock/doctype/stock_entry/stock_entry.py", line 81, in on_submit self.update_stock_ledger() File "/home/travis/frappe-bench/apps/erpnext/erpnext/stock/doctype/stock_entry/stock_entry.py", line 594, in update_stock_ledger self.make_sl_entries(sl_entries, self.amended_from and 'Yes' or 'No') File "/home/travis/frappe-bench/apps/erpnext/erpnext/controllers/stock_controller.py", line 274, in make_sl_entries make_sl_entries(sl_entries, is_amended, allow_negative_stock, via_landed_cost_voucher) File "/home/travis/frappe-bench/apps/erpnext/erpnext/stock/stock_ledger.py", line 33, in make_sl_entries sle_id = make_entry(sle, allow_negative_stock, via_landed_cost_voucher) File "/home/travis/frappe-bench/apps/erpnext/erpnext/stock/stock_ledger.py", line 58, in make_entry sle.submit() File "/home/travis/frappe-bench/apps/frappe/frappe/model/document.py", line 852, in submit self._submit() File "/home/travis/frappe-bench/apps/frappe/frappe/model/document.py", line 841, in _submit self.save() File "/home/travis/frappe-bench/apps/frappe/frappe/model/document.py", line 266, in save return self._save(*args, **kwargs) File "/home/travis/frappe-bench/apps/frappe/frappe/model/document.py", line 319, in _save self.run_post_save_methods() File "/home/travis/frappe-bench/apps/frappe/frappe/model/document.py", line 915, in run_post_save_methods self.run_method("on_submit") File "/home/travis/frappe-bench/apps/frappe/frappe/model/document.py", line 781, in run_method out = Document.hook(fn)(self, *args, **kwargs) File "/home/travis/frappe-bench/apps/frappe/frappe/model/document.py", line 1051, in composer return composed(self, method, *args, **kwargs) File "/home/travis/frappe-bench/apps/frappe/frappe/model/document.py", line 1034, in runner add_to_return_value(self, fn(self, *args, **kwargs)) File "/home/travis/frappe-bench/apps/frappe/frappe/model/document.py", line 775, in <lambda> fn = lambda self, *args, **kwargs: getattr(self, method)(*args, **kwargs) File "/home/travis/frappe-bench/apps/erpnext/erpnext/stock/doctype/stock_ledger_entry/stock_ledger_entry.py", line 44, in on_submit batch.save() File "/home/travis/frappe-bench/apps/frappe/frappe/model/document.py", line 266, in save return self._save(*args, **kwargs) File "/home/travis/frappe-bench/apps/frappe/frappe/model/document.py", line 308, in _save self.validate_update_after_submit() File "/home/travis/frappe-bench/apps/frappe/frappe/model/document.py", line 704, in validate_update_after_submit self._validate_update_after_submit() File "/home/travis/frappe-bench/apps/frappe/frappe/model/base_document.py", line 615, in _validate_update_after_submit frappe.UpdateAfterSubmitError) File "/home/travis/frappe-bench/apps/frappe/frappe/__init__.py", line 352, in throw msgprint(msg, raise_exception=exc, title=title, indicator='red') File "/home/travis/frappe-bench/apps/frappe/frappe/__init__.py", line 338, in msgprint _raise_exception() File "/home/travis/frappe-bench/apps/frappe/frappe/__init__.py", line 311, in _raise_exception raise raise_exception(msg) UpdateAfterSubmitError: Not allowed to change Batch Quantity after submission