Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: General Ledger Group by Voucher not ordering by posting_date for develop #18023

Merged
merged 7 commits into from Jul 14, 2019
Merged

fix: General Ledger Group by Voucher not ordering by posting_date for develop #18023

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
4448e2d
fix order in general ledger
Don-Leopardo Jun 21, 2019
fb2a05c
Merge branch 'develop' into fix_by_voucher_order_develop
Don-Leopardo Jun 24, 2019
c3f6bed
Merge branch 'develop' into fix_by_voucher_order_develop
Don-Leopardo Jun 27, 2019
b2b5c3a
Merge branch 'develop' into fix_by_voucher_order_develop
Don-Leopardo Jun 28, 2019
46b21f8
Merge branch 'develop' into fix_by_voucher_order_develop
Don-Leopardo Jul 2, 2019
85e2fd9
Merge branch 'develop' into fix_by_voucher_order_develop
Don-Leopardo Jul 3, 2019
365a572
Merge branch 'develop' into fix_by_voucher_order_develop
Don-Leopardo Jul 10, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
3 changes: 2 additions & 1 deletion erpnext/accounts/report/general_ledger/general_ledger.py
View file
Open in desktop
Expand Up @@ -11,6 +11,7 @@
from erpnext.accounts.report.financial_statements import get_cost_centers_with_children
from six import iteritems
from erpnext.accounts.doctype.accounting_dimension.accounting_dimension import get_accounting_dimensions
from collections import OrderedDict

def execute(filters=None):
if not filters:
Expand Down Expand Up @@ -274,7 +275,7 @@ def group_by_field(group_by):
return 'voucher_no'

def initialize_gle_map(gl_entries, filters):
gle_map = frappe._dict()
gle_map = OrderedDict()
group_by = group_by_field(filters.get('group_by'))

for gle in gl_entries:
Expand Down