Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: attribute error when trying to fetch items (v11) #18899

Merged
merged 2 commits into from
Sep 5, 2019
Merged

fix: attribute error when trying to fetch items (v11) #18899

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dc7705e
fix: attribute error when trying to fetch items
Sep 3, 2019
ee296a4
Merge branch 'version-11-hotfix' into v11-production-plan-items
nabinhait Sep 3, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions erpnext/manufacturing/doctype/production_plan/production_plan.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def get_items(self):
self.get_mr_items()

def get_so_items(self):
so_list = [d.sales_order for d in self.sales_orders if d.sales_order]
so_list = [d.sales_order for d in self.get("sales_orders", []) if d.sales_order]
if not so_list:
msgprint(_("Please enter Sales Orders in the above table"))
return []
Expand Down Expand Up @@ -132,7 +132,7 @@ def get_so_items(self):
self.calculate_total_planned_qty()

def get_mr_items(self):
mr_list = [d.material_request for d in self.material_requests if d.material_request]
mr_list = [d.material_request for d in self.get("material_requests", []) if d.material_request]
if not mr_list:
msgprint(_("Please enter Material Requests in the above table"))
return []
Expand Down