New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Enabled translation on html files in LMS [Proposal] #21582
feat: Enabled translation on html files in LMS [Proposal] #21582
Conversation
@scmmishra Thanks for the fix. I see github says it is pending for "requested changes" but changes have been applied, is there anything else from my side to do? |
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
What purpose have collaboration in this project?
A Not answered PR that is about to be marked as stale!
I certainly liked frappe and ERPNext but...
El El vie, 5 jun 2020 a las 15:52, stale[bot] <notifications@github.com>
escribió:
This pull request has been automatically marked as stale because it has
not had recent activity. It will be closed within a week if no further
activity occurs, but it only takes a comment to keep a contribution alive
:) Also, even if it is closed, you can always reopen the PR when you're
ready. Thank you for contributing.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#21582 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXSLVEELDOBLXCPDFQOEFLRVD2AVANCNFSM4MYX7DCA>
.
--
Alvaro J. Molano
@AJMolano Tel: + 34 664511782
https://www.linkedin.com/in/alvarojmolano
skype: a.j.molano
|
@Mergifyio backport version-12-hotfix |
Command
|
* :fix: translation fix for html files in LMS * fix: typo in translation * Update content.html * Update content.html * Update profile.html Co-authored-by: Shivam Mishra <scmmishra@users.noreply.github.com> Co-authored-by: Marica <maricadsouza221197@gmail.com> (cherry picked from commit 43be163)
Command
|
…-21582 feat: Enabled translation on html files in LMS [Proposal] (bp #21582)
Hi. I found lms to have missed several strings to be translated.
ie: fragment from course.html
Becomes
I have updated the 8 HTML files with missing translations.
It can be merged into develop, but can also perfectly match version-12
No need for other updates except that not all strings have been added to translation system "csv..."s