Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Enabled translation on html files in LMS [Proposal] #21582

Merged
merged 8 commits into from Jun 22, 2020

Conversation

AlvaroMolano
Copy link
Contributor

Hi. I found lms to have missed several strings to be translated.
ie: fragment from course.html

			<div class='card-footer'>
				{% if progress[topic.name].completed %}
					<span class="indicator green">Completed</span>
				{% elif progress[topic.name].started %}
					<span class="indicator orange">In Progress</span>
				{% else %}
					<span class="indicator blue">Start</span>
				{% endif %}
			</div>

Becomes

			<div class='card-footer'>
				{% if progress[topic.name].completed %}
					<span class="indicator green">{{_('Completed')}}</span>
				{% elif progress[topic.name].started %}
					<span class="indicator orange">{{_('In Progress')}}</span>
				{% else %}
					<span class="indicator blue">{{_('Start')}}</span>
				{% endif %}
			</div>

I have updated the 8 HTML files with missing translations.

It can be merged into develop, but can also perfectly match version-12
No need for other updates except that not all strings have been added to translation system "csv..."s

Please provide enough information so that others can review your pull request:

Explain the details for making this change. What existing problem does the pull request solve?

Screenshots/GIFs

@AlvaroMolano AlvaroMolano changed the title :fix: translation enablement fix for html files in LMS [Proposal] Enabled translation on html files in LMS [Proposal] May 4, 2020
@AlvaroMolano AlvaroMolano changed the title Enabled translation on html files in LMS [Proposal] feat: Enabled translation on html files in LMS [Proposal] May 4, 2020
erpnext/www/lms/content.html Outdated Show resolved Hide resolved
@AlvaroMolano
Copy link
Contributor Author

@scmmishra Thanks for the fix. I see github says it is pending for "requested changes" but changes have been applied, is there anything else from my side to do?

@stale
Copy link

stale bot commented Jun 5, 2020

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Jun 5, 2020
@AlvaroMolano
Copy link
Contributor Author

AlvaroMolano commented Jun 7, 2020 via email

@stale stale bot removed the inactive label Jun 7, 2020
@marination marination self-assigned this Jun 19, 2020
@marination
Copy link
Collaborator

@Mergifyio backport version-12-hotfix

@mergify
Copy link
Contributor

mergify bot commented Jun 22, 2020

Command backport version-12-hotfix: pending

Waiting for the pull request to get merged

@marination marination merged commit 43be163 into frappe:develop Jun 22, 2020
mergify bot pushed a commit that referenced this pull request Jun 22, 2020
* :fix:  translation fix for html files in LMS

* fix: typo in translation

* Update content.html

* Update content.html

* Update profile.html

Co-authored-by: Shivam Mishra <scmmishra@users.noreply.github.com>
Co-authored-by: Marica <maricadsouza221197@gmail.com>
(cherry picked from commit 43be163)
@mergify
Copy link
Contributor

mergify bot commented Jun 22, 2020

Command backport version-12-hotfix: success

Backports have been created

marination added a commit that referenced this pull request Jun 22, 2020
…-21582

feat: Enabled translation on html files in LMS [Proposal] (bp #21582)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants