Stock Ageing TypeError: ‘<’ not supported between instances of ‘int’ … #22206
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deepeshgarg007
requested changes
Jun 11, 2020
| @@ -180,14 +180,14 @@ def get_fifo_queue(filters, sle=None): | |||
| qty_to_pop = abs(d.actual_qty) | |||
| while qty_to_pop: | |||
| batch = fifo_queue[0] if fifo_queue else [0, None] | |||
| if 0 < batch[0] <= qty_to_pop: | |||
| if 0 < cint(batch[0]) <= qty_to_pop: | |||
There was a problem hiding this comment.
flt should be used instead of cint as qty can be fraction value as well
As reviewer Deepesh Garg advised thanks! batch[0] can be int of float - see line 49 - so change proposed cint to flt
clarkejj
commented
Jun 12, 2020
marination
reviewed
Jun 12, 2020
| transferred_item_details[(d.voucher_no, d.name)].append(fifo_queue.pop(0)) | ||
| else: | ||
| # all from current batch | ||
| batch[0] -= qty_to_pop | ||
| flt(batch[0]) -= qty_to_pop |
There was a problem hiding this comment.
Suggested change
| flt(batch[0]) -= qty_to_pop | |
| batch[0] = flt(batch[0]) - qty_to_pop |
Can't assign values to a function call so flt(batch[0]) is problematic
…obvious to me in retrospect, but a good relearning experience in any case
clarkejj
commented
Jun 12, 2020
|
Hi Deepesh and Marica - so once this fix is ok with all checks passing, will you then push this to develop, version-12-hotfix and other backport expected branches where required? |
|
@Mergifyio backport version-12-hotfix |
deepeshgarg007
approved these changes
Jun 12, 2020
|
Excellent thanks for the process learning coaching Deepesh and Marica John |
|
@clarkejj Can you please send these changes on version-12-hotfix as well ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…and ‘str’
Re this user report https://discuss.erpnext.com/t/stock-ageing-report-typeerror-not-supported-between-instances-of-int-and-str/62605
Notes:
ASSUMPTION: This error arises in current version-12 production?
WARNING: This proposed change has not been tested