feat(SLA): Apply SLA to any document #22449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
force-pushed
the
multiple_slas
branch
from
fe17cee
to
a37b0aa
Compare
ruchamahabal
force-pushed
the
multiple_slas
branch
from
08f1f52
to
bcbcb53
Compare
ruchamahabal
force-pushed
the
multiple_slas
branch
from
bcbcb53
to
d645cf5
Compare
erpnext/support/doctype/service_level_agreement/service_level_agreement.py
Show resolved
Hide resolved
ruchamahabal
force-pushed
the
multiple_slas
branch
from
a7cf939
to
d793a1b
Compare
ruchamahabal
force-pushed
the
multiple_slas
branch
from
aecd431
to
940bb85
Compare
|
@hrwX do you remember why you decided to convert timestamps to the user timezone in the backend for this feature? It seems like all other code works with the system timezone in the backend and lets the UI/frontend convert to/from the user timezone. We're currently contemplating to remove this. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables setting Service Level Agreement for any doctype.
Document Type field added to SLA doctype
SLA fields
On creating the SLA, an SLA section will get added to the selected doctype with the following fields (custom fields for standard doctype and docfields for custom doctype).
Hold Time
Hold Time is captured if the Pause SLA On configuration is setup in SLA
sla-hold-time.mp4
SLA Fulfilled On
Allows you to configure statuses for SLA fulfillment
Apply SLA for Resolution Time
For a few instances like applying SLA on leads, there is no resolution SLA required. The only metric that matters is the First Response Time. Hence, the SLA application for resolution time is now optional. If it is disabled, the SLA status is validated as Fulfilled / Failed on the basis of first response time only.
sla-on-response-only.mp4
Hooks
Documentation PR: frappe/erpnext_documentation#340