Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: allow addition and removal of employee in payroll Entry #24169

Merged
merged 4 commits into from Dec 30, 2020

Conversation

Anurag810
Copy link
Contributor

Allow Addition and removal of the employee during payroll. Delete and button is visible now.
Screenshot 2020-12-17 at 3 15 05 PM

abhishekbalam
abhishekbalam previously approved these changes Dec 17, 2020
Copy link
Member

@deepeshgarg007 deepeshgarg007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Anurag810 Its not this simple. Just removing read-only fields won't do. You'll have to filter the employees based on the parameters selected in Payroll Entry. Check for employees whose salary has been already precessed for the current month. Also some employee accruals are also needed to be considered

@dufani1
Copy link

dufani1 commented Dec 18, 2020

This is very good

@dufani1
Copy link

dufani1 commented Dec 18, 2020

@Anurag810 Please add filter of selecting employees based on salary currency

@Anurag810
Copy link
Contributor Author

@Anurag810 Its not this simple. Just removing read-only fields won't do. You'll have to filter the employees based on the parameters selected in Payroll Entry. Check for employees whose salary has been already precessed for the current month. Also some employee accruals are also needed to be considered

done

@rohitwaghchaure rohitwaghchaure merged commit bb0fd33 into frappe:develop Dec 30, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants