fix: Don't validate warehouse values between Material Request and Stock Entry #24294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
marination
commented
Jan 4, 2021
•
marination
commented
- Remove validation that checks if warehouse in Stock Entry is the same as that in the Material Request that it was pulled from.
- The warehouse could change from a Material Request to Stock Entry often as different user roles raise Material Requests and different user roles stock up warehouses.
- Also at the time of creating MR, it is possible that a purchase user wants to issue/receive an Item but does not know from /to which warehouse. Later the stock user will select a warehouse according to stock levels. In such cases also the warehouse will change.
- Material Requests are usually subject to a lot of changes in the real world, so keeping it flexible would be better.
- Remove validation thta checks if warehouse in Stock Entry is the same as MR that it was pulled from
nabinhait
requested changes
Jan 13, 2021
- Make test add mismatched item code instead of warehouse, since warehouse can be different.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.