Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Update total in words after updating items #24592

Merged
merged 2 commits into from Feb 11, 2021

Conversation

ankush
Copy link
Member

@ankush ankush commented Feb 9, 2021

Summary:

  • Update total amount in words when item list is updated in purchase/sales order.
  • Added a basic test for regression.

Closes ISS-20-21-09425

Update total in words after Updating items in sales/purchase orders.

Closes ISS-20-21-09425
Add test for total & words after updating items in sales order.
@ankush ankush marked this pull request as ready for review February 10, 2021 06:06
ankush added a commit to ankush/erpnext that referenced this pull request Feb 10, 2021
Update total in words after Updating items in sales/purchase orders.
Port of frappe#24592

Closes ISS-20-21-09425
nabinhait pushed a commit that referenced this pull request Feb 11, 2021
* fix: Update total in words after Updating items

Update total in words after Updating items in sales/purchase orders.
Port of #24592

Closes ISS-20-21-09425

* test: Add test for total & words after update item

Add test for total & words after updating items in sales order.
@nabinhait nabinhait merged commit 106e0f8 into frappe:version-12-hotfix Feb 11, 2021
@ankush ankush deleted the version-12-hotfix branch February 11, 2021 13:38
nabinhait pushed a commit that referenced this pull request Feb 18, 2021
* fix: Update total in words after Updating items

Update total in words after Updating items in sales/purchase orders.
Port of #24592

Closes ISS-20-21-09425

* test: Add test for total & words after update item

Add test for total & words after updating items in sales order.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants