Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: social media post fixes #24664

Merged
merged 11 commits into from Aug 24, 2021
Merged

refactor: social media post fixes #24664

merged 11 commits into from Aug 24, 2021

Conversation

anupamvs
Copy link
Contributor

@anupamvs anupamvs commented Feb 18, 2021 •
edited

Fixes-

  • Showing tweet content limit.
  • Added documentation link in Twitter Settings and LinkedIn intro text.
  • Added Title field.
  • Enabled Twitter and LinkedIn in the new doc by default.
  • Link preview issue.
  • Some cleanup.
  • Improved error message.
  • added Server-side validation.

Feat-

  • Post metrics
    image
  • Provision to delete the post from social media platform.
    image

Dependent - frappe/frappe#12846

@ruchamahabal ruchamahabal added fix-sider-issues Check and fix issues listed by Sider needs-description labels Feb 23, 2021
@anupamvs anupamvs added WIP and removed fix-sider-issues Check and fix issues listed by Sider needs-description labels Feb 23, 2021
@anupamvs anupamvs force-pushed the sm-fixes branch 4 times, most recently from c1b82ab to 2ecaba4 Compare April 14, 2021 06:42
@anupamvs anupamvs force-pushed the sm-fixes branch 3 times, most recently from cb7c908 to 22dae1d Compare April 14, 2021 11:38
@anupamvs anupamvs removed the WIP label Apr 14, 2021
@anupamvs anupamvs changed the title fix: social media post fixes refactor: social media post fixes Apr 15, 2021
@nabinhait nabinhait changed the base branch from develop to version-13-hotfix May 3, 2021 17:31
@ruchamahabal ruchamahabal added the fix-sider-issues Check and fix issues listed by Sider label Jul 14, 2021
@coveralls
Copy link

coveralls commented Jul 29, 2021 •
edited

Coverage Status

Coverage decreased (-18.7%) to 42.598% when pulling 6c6505a on anupamvs:sm-fixes into ca37380 on frappe:version-13-hotfix.

@anupamvs anupamvs removed the fix-sider-issues Check and fix issues listed by Sider label Jul 29, 2021
@anupamvs
Copy link
Contributor Author

@ruchamahabal can you review this?

@anupamvs anupamvs added backport develop instructs mergify to frontport PR to develop branch squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. labels Jul 31, 2021
@stale
Copy link

stale bot commented Aug 15, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Aug 15, 2021
ruchamahabal
ruchamahabal requested changes Aug 16, 2021
View reviewed changes
erpnext/crm/doctype/social_media_post/social_media_post.js Outdated Show resolved Hide resolved
erpnext/crm/doctype/social_media_post/social_media_post.py Outdated Show resolved Hide resolved
erpnext/crm/doctype/social_media_post/social_media_post.py Outdated Show resolved Hide resolved
erpnext/crm/doctype/social_media_post/social_media_post.py Show resolved Hide resolved
erpnext/crm/doctype/social_media_post/social_media_post.py Outdated Show resolved Hide resolved
erpnext/crm/doctype/social_media_post/social_media_post.py Outdated Show resolved Hide resolved
erpnext/crm/doctype/linkedin_settings/linkedin_settings.py Outdated Show resolved Hide resolved
erpnext/crm/doctype/linkedin_settings/linkedin_settings.py Outdated Show resolved Hide resolved
@stale stale bot removed the inactive label Aug 16, 2021
@anupamvs anupamvs removed the squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. label Aug 17, 2021
@ruchamahabal ruchamahabal merged commit f7e0ede into frappe:version-13-hotfix Aug 24, 2021
@frappe-pr-bot frappe-pr-bot mentioned this pull request Aug 24, 2021
Merged
frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Aug 24, 2021
@anupamvs @frappe-bot
refactor: social media post fixes (frappe#24664)
164acc8 
* fix: social media post fixes

* feat: post metrics and some fixes

* fix: sider issues

* fix: sider issue

* fix: reverting optional chaning statements

* fix: sider issues

* fix: review chnages

* fix: text trigger check

* fix: sider issue

(cherry picked from commit f7e0ede)
This was referenced Sep 1, 2021
Merged
Merged
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@anupamvs @frappe-bot
refactor: social media post fixes (frappe#24664)
62b7660 
* fix: social media post fixes

* feat: post metrics and some fixes

* fix: sider issues

* fix: sider issue

* fix: reverting optional chaning statements

* fix: sider issues

* fix: review chnages

* fix: text trigger check

* fix: sider issue

(cherry picked from commit 5d35f10)
@deepeshgarg007 deepeshgarg007 mentioned this pull request Jul 18, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruchamahabal ruchamahabal ruchamahabal approved these changes

@pateljannat pateljannat Awaiting requested review from pateljannat

Assignees

@ruchamahabal ruchamahabal

Labels
backport develop instructs mergify to frontport PR to develop branch CRM
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@anupamvs @coveralls @ruchamahabal