Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(payroll): allow duplicate additional salaries #24842

Merged
merged 1 commit into from Mar 17, 2021

Conversation

sagarvora
Copy link
Member

@sagarvora sagarvora commented Mar 10, 2021

As discussed in #24824, it can be useful to have multiple additional salaries created separately:

Take Deadline Incentive for example. It may be desirable to show the same component with possibly the same amount multiple times in the Salary Slip. One for each deadline achieved.


In any case, this logic shouldn't be in the before_insert method as one can easily circumvent it by saving with a different amount initially and then re-saving with the desired amount.

@Anurag810 Anurag810 merged commit 23b6294 into frappe:develop Mar 17, 2021
Copy link
Contributor

@Anurag810 Anurag810 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants