Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: serial no trim issue #24949

Merged
merged 5 commits into from Mar 23, 2021
Merged

Conversation

pateljannat
Copy link
Contributor

Issue:

  1. Serial No field for transaction doctypes was causing issues with manual entry as well as entry through a barcode reader.
  2. The unnecessary trim code was causing the cursor to go back to the previous line.

Screen Recording 2021-03-18 at 6 29 58 PM (1)

Steps to replicate:

  1. Create any new transaction document (e.g. Purchase Receipt)
  2. Enter an item and open the item row.
  3. In the Serial no field, enter the serial number.
  4. Then press enter to go to the next line.
  5. The cursor should stay on the new line and should not go back to the previous line.

@dufani1
Copy link

dufani1 commented Mar 19, 2021

This is a serious issue and it is appearing on SI, DN, PI, and PR too.

@nabinhait nabinhait merged commit 12f0923 into frappe:develop Mar 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants