fix: Monthly Attendance Sheet Summarized view #24976
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This fixes the count of different leave types in the monthly attendance sheet summarized view. Signed-off-by: Syed Mujeer Hashmi <mujeerhashmi@4csolutions.in>
mujeerhashmi
requested review from
Anurag810 and
rohitwaghchaure
as code owners
Anurag810
suggested changes
Mar 25, 2021
erpnext/hr/report/monthly_attendance_sheet/monthly_attendance_sheet.py
Outdated
Show resolved
Hide resolved
Signed-off-by: Syed Mujeer Hashmi <mujeerhashmi@4csolutions.in>
|
@Anurag810 Please review. |
ping |
|
@mujeerhashmi will merge this waiting for green checks |
|
@Anurag810 can we get this merged please. |
nabinhait
approved these changes
May 7, 2021
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
* fix: Monthly Attendance Sheet Summarized view This fixes the count of different leave types in the monthly attendance sheet summarized view. Signed-off-by: Syed Mujeer Hashmi <mujeerhashmi@4csolutions.in> * fix: Avoid using raw sql query Signed-off-by: Syed Mujeer Hashmi <mujeerhashmi@4csolutions.in> Co-authored-by: Anurag Mishra <32095923+Anurag810@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the count of different leave types in the monthly
attendance sheet summarized view.
Signed-off-by: Syed Mujeer Hashmi mujeerhashmi@4csolutions.in