feat: added multi-select fields to create multiple pricing rules. #25622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
noahjacob
force-pushed
the
promo_scheme_feat
branch
from
afa823d
to
a2e42dc
Compare
erpnext/accounts/doctype/promotional_scheme/promotional_scheme.py
Outdated
Show resolved
Hide resolved
noahjacob
force-pushed
the
promo_scheme_feat
branch
3 times, most recently
from
928f56d
to
6381a4e
Compare
marination
requested changes
May 18, 2021
erpnext/accounts/doctype/promotional_scheme/promotional_scheme.py
Outdated
Show resolved
Hide resolved
erpnext/accounts/doctype/promotional_scheme/promotional_scheme.py
Outdated
Show resolved
Hide resolved
erpnext/accounts/doctype/promotional_scheme/promotional_scheme.py
Outdated
Show resolved
Hide resolved
erpnext/accounts/doctype/promotional_scheme/promotional_scheme.py
Outdated
Show resolved
Hide resolved
ankush
requested changes
May 23, 2021
erpnext/accounts/doctype/customer_group_item/customer_group_item.py
Outdated
Show resolved
Hide resolved
marination
reviewed
Jul 1, 2021
erpnext/accounts/doctype/promotional_scheme/promotional_scheme.py
Outdated
Show resolved
Hide resolved
|
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
noahjacob
force-pushed
the
promo_scheme_feat
branch
2 times, most recently
from
8501bab
to
dc1894e
Compare
noahjacob
force-pushed
the
promo_scheme_feat
branch
2 times, most recently
from
2ef6cf1
to
09636e3
Compare
|
Really this is good feature and I am waiting to use this feature. |
marination
requested changes
Aug 10, 2021
erpnext/accounts/doctype/promotional_scheme/promotional_scheme.py
Outdated
Show resolved
Hide resolved
erpnext/accounts/doctype/promotional_scheme/promotional_scheme.py
Outdated
Show resolved
Hide resolved
erpnext/accounts/doctype/promotional_scheme/promotional_scheme.py
Outdated
Show resolved
Hide resolved
erpnext/accounts/doctype/promotional_scheme/promotional_scheme.py
Outdated
Show resolved
Hide resolved
erpnext/accounts/doctype/promotional_scheme/promotional_scheme.py
Outdated
Show resolved
Hide resolved
erpnext/accounts/doctype/promotional_scheme/promotional_scheme.py
Outdated
Show resolved
Hide resolved
erpnext/accounts/doctype/promotional_scheme/promotional_scheme.py
Outdated
Show resolved
Hide resolved
marination
reviewed
Aug 10, 2021
marination
reviewed
Aug 10, 2021
noahjacob
force-pushed
the
promo_scheme_feat
branch
from
09636e3
to
49b7c75
Compare
marination
reviewed
Aug 10, 2021
erpnext/accounts/doctype/promotional_scheme/promotional_scheme.py
Outdated
Show resolved
Hide resolved
marination
approved these changes
Aug 10, 2021
marination
added
the
backport develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Feature:
User can select multiple options which creates multiple pricing rules.
On updating promotional scheme, creates new pricing rules if a new option is added.
Updates all pricing rules.
Docs