Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Enable Parallel tests #25635

Merged

Conversation

surajshetty3416
Copy link
Member

@surajshetty3416 surajshetty3416 commented May 8, 2021

Run unit tests parallelly

across multiple instances to reduce wait time for green tick.
(After this the wait time will be down to around ~20 mins from ~42 mins)

  • Fix failing tests
  • Enable coverage for parallel test
  • Fix deprecations warnings for assertEquals

  • Cleaner test reports
    Before:
    Screenshot 2021-05-08 at 1 46 38 PM
    Now:
    Screenshot 2021-05-08 at 1 47 35 PM

Dependent on frappe/frappe#13165
Note: This is dependant on test orchestrator to balance test time across instances (to avoid this).

@surajshetty3416
Copy link
Member Author

surajshetty3416 commented May 9, 2021

Build time across instances is not balanced and is highly uneven.

Screenshot 2021-05-08 at 8 47 38 PM

@Alchez
Copy link
Contributor

Alchez commented May 9, 2021

@surajshetty3416, can we not salvage anything from this? The cleaner reports are a good change.

@surajshetty3416
Copy link
Member Author

surajshetty3416 commented May 9, 2021

@Alchez I'll reopen this with a better solution... Stay Tuned!

- Rename TestSubcontractedItemToBeReceived > TestSubcontractedItemToBeTransferred
- fixes: "Please set a default Holiday List for Employee EMP-00009 or Company Wind Power LLC" error
@surajshetty3416 surajshetty3416 marked this pull request as ready for review May 10, 2021 15:25
@surajshetty3416 surajshetty3416 merged commit 14ca9ce into frappe:develop May 13, 2021
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants