Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: leave balance report #25771

Merged
merged 2 commits into from Jun 1, 2021
Merged

refactor: leave balance report #25771

merged 2 commits into from Jun 1, 2021

Conversation

pateljannat
Copy link
Contributor

@pateljannat pateljannat commented May 20, 2021 •
edited

Fixes in Leave Balance Report

  • Set Leave Period from_date and to_date as a default filter for dates.
  • Removed unused lines of code
  • Added Charts

Screenshot 2021-05-20 at 3 55 44 PM

Documentation: frappe/erpnext_documentation#330

@pateljannat pateljannat requested review from ruchamahabal and removed request for rohitwaghchaure and Anurag810 May 20, 2021 14:43
@pateljannat pateljannat added the HR label May 20, 2021
@ruchamahabal ruchamahabal self-assigned this May 21, 2021
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.04%) to 61.184% when pulling 2167181 on pateljannat:leave-balance-report-refactor-v13 into 181c5d2 on frappe:version-13-hotfix.

@ruchamahabal ruchamahabal merged commit 1175e06 into frappe:version-13-hotfix Jun 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruchamahabal ruchamahabal ruchamahabal approved these changes

Assignees

@ruchamahabal ruchamahabal

Labels
HR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pateljannat @coveralls @ruchamahabal