Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: Remove redundant variables.scss import #25824

Merged

Conversation

surajshetty3416
Copy link
Member

@surajshetty3416 surajshetty3416 commented May 25, 2021

variables.scss file import is unnecessary since CSS variables will be available globally via Frappe.

It also overwrites some style set by Frappe (this issue got introduced after #25623)

Dependent on frappe/frappe#13333

@surajshetty3416 surajshetty3416 merged commit 3563454 into frappe:develop May 25, 2021
@surajshetty3416 surajshetty3416 deleted the fix-variables-import branch May 25, 2021 10:39
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant