Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cost center & account validation in Sales/Purchase Taxes and Charges #25929

Merged
merged 24 commits into from
Aug 10, 2021

Conversation

Anuja-pawar
Copy link
Contributor

@Anuja-pawar Anuja-pawar commented Jun 3, 2021

Issue: Currently, there is no validation for the cost center in the Sales/Purchase Taxes and Charges Template, which further causes issues while creating purchase/sales invoices.

Steps to replicate:

  1. Create Sales/Purchase Taxes and Charges Template
  2. Change the Company in that form after entering the values in the taxes table
  3. Create Sales/Purchase Invoice and include that tax template

You would get an error as shown below even though you select the correct cost center in Sales/Purchase Invoice and its item table
ezgif com-gif-maker (2)
because the wrong cost center is fetched in the taxes table.

@ankush ankush added the CI-failing Unit tests or patch tests are failing. label Jun 3, 2021
@nextchamp-saqib
Copy link
Member

@Anuja-pawar There's a bunch of failing tests since the validation is working. You will have to fix them now. 😅

@nextchamp-saqib nextchamp-saqib changed the base branch from version-13-hotfix to develop July 1, 2021 08:14
@stale
Copy link

stale bot commented Jul 21, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Jul 21, 2021
@stale stale bot closed this Jul 24, 2021
@Anuja-pawar Anuja-pawar reopened this Jul 28, 2021
@stale stale bot removed the inactive label Jul 28, 2021
@Anuja-pawar Anuja-pawar removed the CI-failing Unit tests or patch tests are failing. label Jul 29, 2021
@coveralls
Copy link

coveralls commented Aug 9, 2021

Coverage Status

Coverage increased (+0.05%) to 42.756% when pulling 97372fd on Anuja-pawar:fix-cost-center-validation into 7ba8c82 on frappe:develop.

@nextchamp-saqib nextchamp-saqib merged commit 0e337be into frappe:develop Aug 10, 2021
frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Aug 10, 2021
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants