-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: cost center & account validation in Sales/Purchase Taxes and Charges #25929
fix: cost center & account validation in Sales/Purchase Taxes and Charges #25929
Conversation
@Anuja-pawar There's a bunch of failing tests since the validation is working. You will have to fix them now. 😅 |
…-pawar/erpnext into fix-cost-center-validation
…-pawar/erpnext into fix-cost-center-validation
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing. |
…rges (frappe#25929) (cherry picked from commit 0e337be)
Issue: Currently, there is no validation for the cost center in the Sales/Purchase Taxes and Charges Template, which further causes issues while creating purchase/sales invoices.
Steps to replicate:
You would get an error as shown below even though you select the correct cost center in Sales/Purchase Invoice and its item table
because the wrong cost center is fetched in the taxes table.