Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: staffing plan vacancies data type issue #25936

Merged
merged 5 commits into from
Jun 23, 2021
Merged

fix: staffing plan vacancies data type issue #25936

merged 5 commits into from
Jun 23, 2021

Conversation

pateljannat
Copy link
Contributor

Issue and steps to replicate.

  1. Create a Staffing plan for a designation that has at least one employee already present.
  2. In the Staffing Plan Details table enter that designation. Observe the Number of Positions auto-populate. It should be greater than 0 for this scenario.
  3. Don't enter any vacancy. Leave the field blank.
  4. Save.

Actual Result

  1. An Error used to appear due to inconsistencies in data types.

Screenshot 2021-06-03 at 4 02 21 PM

Expected Result

  1. It should save without any error.

@pateljannat pateljannat requested review from ruchamahabal and removed request for rohitwaghchaure and Anurag810 June 3, 2021 10:40
This was referenced Jun 3, 2021
Merged
Merged
ruchamahabal
ruchamahabal previously approved these changes Jun 23, 2021
View reviewed changes
@ruchamahabal
Copy link
Member

Unrelated test case failing. Merging

@ruchamahabal ruchamahabal merged commit da66cef into frappe:develop Jun 23, 2021
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@pateljannat @ruchamahabal
fix: staffing plan vacancies data type issue (frappe#25936)
2509afe 
* fix: staffing plan vacancies data type issue

* fix: translation issue

* fix: removed greater than 0 condition

* fix: sider

Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruchamahabal ruchamahabal ruchamahabal left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@pateljannat @ruchamahabal