fix: boarding status in Employee Onboarding and Separation #25944
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruchamahabal
requested review from
Anurag810,
nextchamp-saqib and
rohitwaghchaure
as code owners
- make boarding status read-only as its dependent on project - update boarding status in onboarding/separation on project update - update tests to check status changes
ruchamahabal
force-pushed
the
fix-employee-onboarding-status
branch
from
c8979a5
to
67519d6
Compare
nabinhait
requested changes
Jun 24, 2021
erpnext/hr/utils.py
Outdated
| @@ -114,16 +114,23 @@ def get_onboarding_details(parent, parenttype): | |||
| filters={"parent": parent, "parenttype": parenttype}, | |||
| order_by= "idx") | |||
|
|
|||
| @frappe.whitelist() | |||
| def get_boarding_status(project): | |||
| def update_employee_boarding_status(project): | |||
There was a problem hiding this comment.
Why employee onboarding related functions and common class in hr/utils? Creating a separate file or putting in employee_onboarding.py will make more sense.
ruchamahabal
force-pushed
the
fix-employee-onboarding-status
branch
from
e0203ce
to
357657f
Compare
nabinhait
approved these changes
Jul 29, 2021
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
…ding-status fix: boarding status in Employee Onboarding and Separation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Steps to replicate:
This is because Employee Onboarding fetches the status from the linked Project on load and overrides manually set status. The document is set as dirty so even though you did not make any changes on opening it you have to save it with the updated status.
The same thing happens with the Employee Separation doctype too.
employee-onboarding-before.mp4
Fix:
update_employee_boarding_statusto update boarding status on updating the project.employee-onboarding-after.mp4