feat: Exchange rate difference handling in procurement cycle #25970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GangaManoj
requested review from
deepeshgarg007,
marination,
nextchamp-saqib and
rohitwaghchaure
as code owners
deepeshgarg007
requested changes
Jun 15, 2021
GangaManoj
force-pushed
the
exchange-rate-difference-handling
branch
from
3aa5d68
to
d748e7f
Compare
This reverts commit feed97e.
deepeshgarg007
approved these changes
Jun 30, 2021
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
…nce-handling feat: Exchange rate difference handling in procurement cycle
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
When a Purchase Invoice is created from a Purchase Receipt(or vice versa), if the exchange rate is different at the time of creation of the latter, the GL entries created for the Stock Received But Not Billed account will not be balanced.
Fix:
The amount for the Stock Received But Not Billed account for the second transaction will be made equal to that of the first and the difference will be assigned to the Exchange Gain/Loss account.
Case 1: The Purchase Receipt is created first at a particular exchange rate, but the exchange rate at the time of creation of the Purchase Invoice is different.
Images
For the Purchase Receipt:
For the corresponding Purchase Invoice(created after the exchange rate was changed):
Case 2: The Purchase Invoice is created first at a particular exchange rate, but the exchange rate at the time of creation of the Purchase Receipt is different.
Images
For the Purchase Invoice:
For the corresponding Purchase Receipt(created after the exchange rate was changed):
no-docs