fix: Update leave allocation after submit #25975
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pateljannat
commented
Jun 7, 2021
•
pateljannat
commented
- Previously, users could not modify the number of leaves once a Leave Allocation was submitted.
- In scenarios where the user had made a mistake in the leaves allocated, there was no easy way to rectify it.
- The only way was to cancel and amend the Leave Allocation, but this was not feasible if there were approved Leave applications for this allocation.
- Now, the users can update the New Leaves Allocated field after submit as well.
- Leave Ledger Entries will be created accordingly for the modified leaves.
- If the user makes the number of new leaves allocated lesser than the leaves applications approved for that period, a validation message will be shown.
gavindsouza
requested changes
Jun 8, 2021
….com/pateljannat/erpnext into update-leave-allocation-after-submit
nabinhait
approved these changes
Jun 23, 2021
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
* update leave allocation after submit * fix: leave allocation update after submit * fix: circular dependency * fix: replaced update with submit in tests * fix: replaced update with submit in tests * fix: updating total leaves allocated
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.