-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: validate Product Bundle for existing transactions before deletion #25977
Merged
nextchamp-saqib
merged 33 commits into
frappe:develop
from
AfshanKhan:validate-product-bundle-deletion
Jul 1, 2021
Merged
fix: validate Product Bundle for existing transactions before deletion #25977
nextchamp-saqib
merged 33 commits into
frappe:develop
from
AfshanKhan:validate-product-bundle-deletion
Jul 1, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fix: Error Message
AfshanKhan
changed the title
Validate Product Bundle for existing transactions before deletion
fix: validate Product Bundle for existing transactions before deletion
Jun 8, 2021
nextchamp-saqib
requested changes
Jun 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should also provide a disable checkbox similar to item master to disable any specific product bundle
nextchamp-saqib
requested changes
Jun 16, 2021
Co-authored-by: Saqib <nextchamp.saqib@gmail.com>
…-bundle-deletion Merge remote-tracking branch 'upstream/develop' into validate-product-bundle-deletion
…/AfshanKhan/erpnext into validate-product-bundle-deletion Merge branch 'validate-product-bundle-deletion' of https://github.com/AfshanKhan/erpnext into validate-product-bundle-deletion
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The user can delete Product Bundles even if a transaction exists against them.
Steps to replicate
Enhancement
Now there is a validation to check if any transaction exists for the product bundle and the following message is displayed to the user when they try deleting any Product Bundle.