Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: validate Product Bundle for existing transactions before deletion #25977

Merged

Conversation

AfshanKhan
Copy link
Contributor

Problem

The user can delete Product Bundles even if a transaction exists against them.

Steps to replicate

  1. Create a Product Bundle.
  2. Create a Sales Invoice with the Item as the Product Bundle.
  3. Now delete the Product Bundle.

Enhancement

Now there is a validation to check if any transaction exists for the product bundle and the following message is displayed to the user when they try deleting any Product Bundle.
image

fix: Error Message
@AfshanKhan AfshanKhan changed the title Validate Product Bundle for existing transactions before deletion fix: validate Product Bundle for existing transactions before deletion Jun 8, 2021
Copy link
Member

@deepeshgarg007 deepeshgarg007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should also provide a disable checkbox similar to item master to disable any specific product bundle

Co-authored-by: Saqib <nextchamp.saqib@gmail.com>
@coveralls
Copy link

coveralls commented Jun 24, 2021

Coverage Status

Coverage decreased (-0.05%) to 42.722% when pulling 100032a on AfshanKhan:validate-product-bundle-deletion into ac0bc1f on frappe:develop.

@nextchamp-saqib nextchamp-saqib merged commit 81522ec into frappe:develop Jul 1, 2021
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants