Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Issue): Calculate first_response_time based on working hours #25991

Merged
merged 19 commits into from
Jul 14, 2021
Merged

fix(Issue): Calculate first_response_time based on working hours #25991

merged 19 commits into from
Jul 14, 2021

Conversation

GangaManoj
Copy link
Contributor

Problem:
First Response Time calculation does not take working hours into consideration- it just takes the difference between first_responded_on and time of creation of the Issue.

Fix:
Checks if first_responded_on and time of creation of the Issue are:

  • on the same day
  • during working hours
  • on working days

@GangaManoj GangaManoj requested review from nextchamp-saqib and removed request for marination June 9, 2021 00:29
@GangaManoj GangaManoj mentioned this pull request Jun 9, 2021
Closed
@nextchamp-saqib nextchamp-saqib self-assigned this Jun 9, 2021
@nextchamp-saqib nextchamp-saqib changed the base branch from version-13-hotfix to develop June 22, 2021 09:43
@nextchamp-saqib nextchamp-saqib added CI-failing Unit tests or patch tests are failing. fix-sider-issues Check and fix issues listed by Sider labels Jun 23, 2021
@nextchamp-saqib nextchamp-saqib removed fix-sider-issues Check and fix issues listed by Sider CI-failing Unit tests or patch tests are failing. labels Jun 24, 2021
nextchamp-saqib
nextchamp-saqib requested changes Jun 24, 2021
View reviewed changes
erpnext/support/doctype/issue/issue.py Outdated Show resolved Hide resolved
erpnext/support/doctype/issue/issue.py Outdated Show resolved Hide resolved
@coveralls
Copy link

coveralls commented Jun 24, 2021 •
edited

Coverage Status

Coverage remained the same at 42.908% when pulling b5784c4 on GangaManoj:fix-frt-calculation into 8ebf32e on frappe:develop.

@GangaManoj @nextchamp-saqib
fix: Improve filters for checking for first response
f40cb9c 
Co-authored-by: Saqib <nextchamp.saqib@gmail.com>
@nextchamp-saqib nextchamp-saqib added the CI-failing Unit tests or patch tests are failing. label Jul 12, 2021
@nextchamp-saqib nextchamp-saqib removed the CI-failing Unit tests or patch tests are failing. label Jul 13, 2021
@nextchamp-saqib nextchamp-saqib merged commit f4fc138 into frappe:develop Jul 14, 2021
@GangaManoj GangaManoj mentioned this pull request Jul 15, 2021
Merged
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@GangaManoj
fix(Issue): Calculate first_response_time based on working hours (fra…
2c11a65 
…ppe#25991)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nextchamp-saqib nextchamp-saqib nextchamp-saqib requested changes

Assignees

@nextchamp-saqib nextchamp-saqib

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@GangaManoj @coveralls @nextchamp-saqib