Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Report Subcontracted Raw Materials to be Transferred #26020

Conversation

marination
Copy link
Collaborator

Before:

  • Over complicated logic (since there was no proper linking between PO and Stock Entry back then)
  • Shows pending qty as negative on over transferring
  • Also showed all Purchase Orders even if they were fully received. (nothing left to transfer)
  • If multiple rows of the same raw material exist in the PO, it counts transferred qty as sum of all the rows. The key here was "Raw Material Item Code" which is incorrect in case of multiple rows with the same item code but belonging to different Finished Goods.
    Screenshot 2021-06-10 at 9 27 28 PM

After:

  • Simplified logic
  • Only show information from POs that are yet to be received and have pending qty to transfer
  • Inaccurate pending qty in case of same Raw Material Item Code fixed
    Screenshot 2021-06-10 at 9 23 24 PM

Did not enhance this report too much. When #25878 gets merged, it can deprecate this report easily.

@marination marination merged commit 326a2e6 into frappe:develop Jun 14, 2021
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
…ransfer-report-develop

fix: Report Subcontracted Raw Materials to be Transferred
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant