Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: escaped warehouse value for sql query #26049

Merged
merged 1 commit into from
Jun 15, 2021
Merged

fix: escaped warehouse value for sql query #26049

merged 1 commit into from
Jun 15, 2021

Conversation

noahjacob
Copy link
Contributor

Issue:

  • Unescaped warehouse name values would throw a query syntax error if contained special characters like " ' " while trying to create a stock ledger entry.(Eg. SOMEONE ' S SUPERMARKET )

Fix:

  • Escaped warehouse name fields for query.

@ankush ankush merged commit b5a1491 into frappe:version-13-hotfix Jun 15, 2021
@ankush
Copy link
Member

ankush commented Jun 15, 2021

@noahjacob can you backport it to develop as well?

@ankush ankush added the backport develop instructs mergify to frontport PR to develop branch label Jun 15, 2021
@ankush ankush mentioned this pull request Jun 18, 2021
Merged
ankush pushed a commit to ankush/erpnext that referenced this pull request Jun 18, 2021
@noahjacob @ankush
fix: escaped warehouse value for sql query (frappe#26049)
0c021d8
@ankush ankush removed the backport develop instructs mergify to frontport PR to develop branch label Jun 18, 2021
ankush added a commit that referenced this pull request Jun 18, 2021
@ankush @noahjacob
fix: escaped warehouse value for sql query (bp #26049)
584fe32 
Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com>
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@ankush @noahjacob
fix: escaped warehouse value for sql query (bp frappe#26049)
f488028 
Co-authored-by: Noah Jacob <noahjacobkurian@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankush ankush ankush approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@noahjacob @ankush