Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cannot cancel payment entry if linked with invoices #26075

Merged

Conversation

nextchamp-saqib
Copy link
Member

If a Sales Invoice is linked with a Payment Entry through the Advances table, then the user cannot cancel the Payment Entry without cancelling the Sales Invoice

Previously, in v12, this was allowed, and even in v13, the business logic is there but the "Cancel All" feature unintentionally broke the feature.

Steps to replicate

  • Create a Payment Entry against a Customer
  • Create a Sales Invoice against the same customer & allocate advance & submit
  • Now try cancelling the Payment Entry, it should ask you to cancel the Sales Invoice along with the Payment Entry.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.06%) to 42.63% when pulling 821ffbf on nextchamp-saqib:cannot-cancel-payment-entry into 6894cc2 on frappe:develop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants