Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(e-invoicing): IRN generation for export invoices with round off #26076

Merged
merged 3 commits into from
Jun 22, 2021
Merged

fix(e-invoicing): IRN generation for export invoices with round off #26076

merged 3 commits into from
Jun 22, 2021

Conversation

nextchamp-saqib
Copy link
Member

@nextchamp-saqib nextchamp-saqib commented Jun 16, 2021 •
edited

Fix e-invoice validations to consider round off amount in sales invoices

Steps to replicate:

  • Create a Sales Invoice with some rounding adjustment
  • Generating IRN throws following error

CleanShot 2021-06-16 at 19 03 43@2x

@coveralls
Copy link

Coverage Status

Coverage remained the same at 42.697% when pulling d8d3e53 on nextchamp-saqib:export-round-off-fix into 7ff19eb on frappe:develop.

@deepeshgarg007 deepeshgarg007 merged commit dc6e4f1 into frappe:develop Jun 22, 2021
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@deepeshgarg007
Merge pull request frappe#26076 from nextchamp-saqib/export-round-off…
08e9fec 
…-fix

fix(e-invoicing): IRN generation for export invoices with round off
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepeshgarg007 deepeshgarg007 deepeshgarg007 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nextchamp-saqib @coveralls @deepeshgarg007