Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(pos): unsupported operand type -= for 'float' and 'NoneType' #26096

Merged
merged 3 commits into from
Jun 21, 2021
Merged

fix(pos): unsupported operand type -= for 'float' and 'NoneType' #26096

merged 3 commits into from
Jun 21, 2021

Conversation

nextchamp-saqib
Copy link
Member

Fix:

File "/home/frappe/frappe-bench/apps/erpnext/erpnext/accounts/doctype/sales_invoice/sales_invoice.py", line 214, in on_submit
    self.make_gl_entries()
  File "/home/frappe/frappe-bench/apps/erpnext/erpnext/accounts/doctype/sales_invoice/sales_invoice.py", line 814, in make_gl_entries
    gl_entries = self.get_gl_entries()
  File "/home/frappe/frappe-bench/apps/erpnext/erpnext/accounts/doctype/sales_invoice/sales_invoice.py", line 853, in get_gl_entries
    self.make_pos_gl_entries(gl_entries)
  File "/home/frappe/frappe-bench/apps/erpnext/erpnext/accounts/doctype/sales_invoice/sales_invoice.py", line 992, in make_pos_gl_entries
    payment_mode.base_amount -= self.change_amount
TypeError: unsupported operand type(s) for -=: 'float' and 'NoneType'

@nextchamp-saqib nextchamp-saqib changed the title fix(pos): unsupported operand type -=: for 'float' and 'NoneType' fix(pos): unsupported operand type -= for 'float' and 'NoneType' Jun 17, 2021
@nextchamp-saqib nextchamp-saqib mentioned this pull request Jun 17, 2021
Merged
@nextchamp-saqib nextchamp-saqib mentioned this pull request Jun 21, 2021
Merged
@nextchamp-saqib nextchamp-saqib merged commit 7ff19eb into frappe:develop Jun 21, 2021
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@nextchamp-saqib
fix(pos): unsupported operand type -= for 'float' and 'NoneType' (fra…
340ff93 
…ppe#26096)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deepeshgarg007 deepeshgarg007 Awaiting requested review from deepeshgarg007 deepeshgarg007 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@nextchamp-saqib