fix: fixed rounding off ordered percent to 100 in condition #26148
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
previously approved these changes
Jun 22, 2021
noahjacob
force-pushed
the
material_request_ordered_per_fix
branch
from
33b0d7a
to
509dfd4
Compare
ankush
approved these changes
Jun 22, 2021
ruchamahabal
pushed a commit
to ruchamahabal/erpnext
that referenced
this pull request
Jun 23, 2021
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue:
if (flt(frm.doc.per_ordered, 2) < 100)After Fix:
Related Fix - PR #24019