fix: Changed profitability analysis report width #26150
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesis189
requested review from
deepeshgarg007 and
nextchamp-saqib
as code owners
| @@ -168,21 +168,24 @@ def get_columns(filters): | |||
| "label": _("Income"), | |||
| "fieldtype": "Currency", | |||
| "options": "currency", | |||
| "width": 120 | |||
| "width": 305 | |||
There was a problem hiding this comment.
@nemesis189 Can you add some screenshots of the report in description. Want to see how it looks now. Also why 305 and 307 and not some rounded whole no like 320 or 300?
There was a problem hiding this comment.
adjusted the values for the table to fit the whole display, lesser values would leave a noticeable amount of space and looks quite asymmetric
deepeshgarg007
approved these changes
Jun 23, 2021
|
@nemesis189 backport this to version-13-hotfix branch too |
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
…-analysis-report-width fix: Changed profitability analysis report width
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusted the width of Profitability Analysis Report to fit the screen and reduce white space
Before
After
