perf: don't query unless required #26175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ankush
force-pushed
the
perf_cache_invariants
branch
2 times, most recently
from
7d4139e
to
3e9212c
Compare
ankush
changed the title
re-order conditionals so queries are no evaluated, unless required.
ankush
force-pushed
the
perf_cache_invariants
branch
from
3e9212c
to
bb4d71e
Compare
ankush
added a commit
to ankush/erpnext
that referenced
this pull request
Jun 24, 2021
re-order conditionals so queries are not evaluated unless required. # Conflicts: # erpnext/stock/doctype/batch/batch.py
ankush
added a commit
that referenced
this pull request
Jun 24, 2021
re-order conditionals so queries are not evaluated unless required. # Conflicts: # erpnext/stock/doctype/batch/batch.py
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
re-order conditionals so queries are not evaluated unless required.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reordering conditionals so queries are not performed unless absolutely required.
Essentially, both options below are semantically the same but one will always hit the DB before evaluating to
False.False and frappe.db.sql("select * from tabItem")frappe.db.sql("select * from tabItem") and False