Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: order and time of operations in multilevel BOM work order (fp #25886) #26224

Conversation

ankush
Copy link
Member

@ankush ankush commented Jun 25, 2021

Backports the following commits to develop:

  • chore: remove dead and py2 compatibility code (ff4aadc)
  • fix(ux): show bom in operations child table (6ec8875)
  • fix: order and time of operations for multilevel bom (9e43445)

form_grid_template doesn't exist
# Conflicts:
#	erpnext/manufacturing/doctype/work_order_operation/work_order_operation.json
- Order of operations was being sorted by idx of individual operations in
BOM table, which made the ordering useless.
- This adds ordering that's sorted from lowest level item to top level
item.
- chore: remove dead functionality. There's no `items` table. Required
  item level operations get overwritten on fetching of items /
  operations e.g. when clicking on multi-level BOM checkbox.
- test: add test for tree representation
- feat: BOMTree class to get complete representation of a tree
@ankush ankush added the backport This is a backported PR label Jun 25, 2021
@ankush ankush changed the title chore: remove dead and py2 compatibility code (ff4aadc6) | fix(ux): show bom in operations child table (6ec88754) | fix: order and time of operations for multilevel bom (9e43445f) fix: order and time of operations in multilevel BOM work order (fp #25886) Jun 25, 2021
@ankush ankush merged commit 805ac4f into frappe:develop Jun 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport This is a backported PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant