fix: Added a message to enable appointment booking if disabled #26233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
ruchamahabal
approved these changes
Jul 2, 2021
|
Congratulations on your first contribution 🥳 |
|
@mohammedyusufshaikh please backport the same for |
|
ok |
|
If appointment scheduling is disabled the link for appointment booking in the portal for customer/supplier shouldn't appear? Just as a better experience for customer/supplier? |
|
@chrisdent Yes, that's always better but currently the standard portal menu items are hardcoded in Line 189 in 2af6ea6 The framework allows you to create your own website sidebar to override this. |
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
…e#26233) * fix: Added a message to enable appointment booking if disabled * refactor: added translation for the message Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com> * fix: added missing import * fix: minor identation and space fix Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initially If the appointment scheduling was disabled it use to route to 404 page but after the fix it shows a message to the user to enable the appointment booking scheduling from appointment booking settings
Resolves Issue #25965