Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: lms progress issue #26250

Merged
merged 2 commits into from
Jul 2, 2021
Merged

Conversation

pateljannat
Copy link
Contributor

Issue:

  1. For LMS, enroll in Program but don't enroll in its courses.
  2. Visit the LMS. Click on the Program. It results in an error.

image

Traceback (most recent call last):
  File "/home/frappe/frappe-io-bench/apps/frappe/frappe/website/render.py", line 49, in render
    data = render_page_by_language(path)
  File "/home/frappe/frappe-io-bench/apps/frappe/frappe/website/render.py", line 178, in render_page_by_language
    return render_page(path)
  File "/home/frappe/frappe-io-bench/apps/frappe/frappe/website/render.py", line 194, in render_page
    return build(path)
  File "/home/frappe/frappe-io-bench/apps/frappe/frappe/website/render.py", line 201, in buildreturn build_page(path)
  File "/home/frappe/frappe-io-bench/apps/frappe/frappe/website/render.py", line 224, in build_page
    html = frappe.get_template(context.template).render(context)
  File "/home/frappe/frappe-io-bench/env/lib/python3.6/site-packages/jinja2/environment.py", line 1090, in render
    self.environment.handle_exception()
  File "/home/frappe/frappe-io-bench/env/lib/python3.6/site-packages/jinja2/environment.py", line 832, in handle_exception
    reraise(*rewrite_traceback_stack(source=source))
  File "/home/frappe/frappe-io-bench/env/lib/python3.6/site-packages/jinja2/_compat.py", line 28, in reraise
    raise value.with_traceback(tb)
  File "/home/frappe/frappe-io-bench/apps/erpnext/erpnext/./www/lms/program.html", line 62, in top-level template code
    <span class="indicator blue">{{_('Start')}}</span>
  File "/home/frappe/frappe-io-bench/apps/frappe/frappe/./templates/base.html", line 83, in top-level template code
    {% block content %}
  File "/home/frappe/frappe-io-bench/apps/erpnext/erpnext/./www/lms/program.html", line 77, in block "content"
    {{ card(course) }}
  File "/home/frappe/frappe-io-bench/env/lib/python3.6/site-packages/jinja2/sandbox.py", line 462, in callreturn __context.call(__obj, *args, **kwargs)
  File "/home/frappe/frappe-io-bench/env/lib/python3.6/site-packages/jinja2/runtime.py", line 679, in _invoke
    rv = self._func(*arguments)
  File "/home/frappe/frappe-io-bench/apps/erpnext/erpnext/./www/lms/program.html", line 55, in template
    {% if has_access and progress[course.name] %}
  File "/home/frappe/frappe-io-bench/env/lib/python3.6/site-packages/jinja2/sandbox.py", line 384, in getitem
    return obj[argument]
jinja2.exceptions.UndefinedError: 'progress' is undefined

@ruchamahabal ruchamahabal merged commit 0a15a03 into frappe:develop Jul 2, 2021
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants