New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Order Items by weightage in the web items query #26284

Merged

marination merged 1 commit into frappe:version-13-hotfix from marination:order-by-weightage-for-web-items

Jul 6, 2021

Collaborator

marination commented Jul 1, 2021 •

edited

Issue:

Query engine first queried items in any order, with a page limit and then sorted the results by weightage
So items having much higher weightage , which were modified long back, and are ay down the items list don't come up

Fix:

order items in query and then again after including website item groups

To Test:

Have 10 Items with show in website enabled. Set weightage in each.
Make sure the highest weightage item is has the oldest modified time (in the Item List on Desk it should be somewhere at the bottom)
Set Products per Page to 5 in Product Settings.
Check if this item shows up on the first page of the website product listing


          fix: Order Items by weightage in the web items query

752f099

marination merged commit dfe11ac into frappe:version-13-hotfix

marination added the backport develop label

marination mentioned this pull request

fix: Order Items by weightage in the web items query #26401

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment