Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: added company filter while fetching loans #26295

Merged
merged 5 commits into from
Jul 12, 2021

Conversation

pateljannat
Copy link
Contributor

Company filter for Loan Type

  1. While creating a Loan or Loan Application, it should only display the loan types that fall under the company that's selected.

Screenshot 2021-07-02 at 10 57 34 AM

Salary Slip

  1. When a salary slip is created it should only consider the loan that's taken from the company that's selected in the salary slip.

@pateljannat pateljannat added the HR label Jul 2, 2021
@ruchamahabal ruchamahabal merged commit b4ea185 into frappe:develop Jul 12, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+0.03%) to 42.837% when pulling 86f51a2 on pateljannat:loan-validations into e2c97b1 on frappe:develop.

asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
* fix: added company filter while fetching loans

* fix: added set_query in refresh

* fix: quotes

* fix: tests

Co-authored-by: Rucha Mahabal <ruchamahabal2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants