Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add french address template #26316

Merged
merged 9 commits into from
Aug 9, 2021

Conversation

FHenry
Copy link
Contributor

@FHenry FHenry commented Jul 3, 2021

add french address template

no-docs

@FHenry FHenry changed the title NEW : add french address template NEW: add french address template Jul 3, 2021
@FHenry FHenry changed the title NEW: add french address template new: add french address template Jul 3, 2021
@FHenry FHenry changed the title new: add french address template fix: add french address template Jul 3, 2021
@FHenry FHenry changed the title fix: add french address template feat: add french address template Jul 3, 2021
@stale
Copy link

stale bot commented Jul 20, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Jul 20, 2021
@ankush ankush added regional squash Meant to tell reviewers that this PR should be squashed into a single commit while merging. labels Aug 6, 2021
Co-authored-by: Ankush <ankushmenat@gmail.com>
Copy link
Contributor Author

@FHenry FHenry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In france adress are
"Digit street number" "name of the street"
"ZipCode" (ak pincode in ERPNext, number id of the city in french postal codification) "city name" (on the same line)
"Country"

For exemple :
8 rue des arbres
26000 VALENCE
France

There region or county but they are never display on adress.
Same as Email or phone number, the postman don't need to know this personal information

erpnext/regional/address_template/templates/france.html Outdated Show resolved Hide resolved
remove state never use in display french adress
@coveralls
Copy link

coveralls commented Aug 7, 2021

Coverage Status

Coverage increased (+0.02%) to 42.718% when pulling 5a7fdc4 on FHenry:dev_add_french_address_template into 27a29eb on frappe:develop.

@ankush ankush merged commit 07e65ab into frappe:develop Aug 9, 2021
frappe-pr-bot pushed a commit to frappe-pr-bot/erpnext that referenced this pull request Aug 9, 2021
* add french address template

Co-authored-by: Ankush <ankush@iwebnotes.com>
(cherry picked from commit 07e65ab)
ankush pushed a commit that referenced this pull request Aug 9, 2021
* add french address template

Co-authored-by: HENRY Florian <florian.henry@open-concept.pro>

(cherry picked from commit 07e65ab)
@FHenry FHenry deleted the dev_add_french_address_template branch August 16, 2021 08:07
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
* add french address template

Co-authored-by: Ankush <ankush@iwebnotes.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport version-13-hotfix regional squash Meant to tell reviewers that this PR should be squashed into a single commit while merging.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants