Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: value fetching for custom field in POS #26366

Merged
merged 1 commit into from
Jul 9, 2021
Merged

fix: value fetching for custom field in POS #26366

merged 1 commit into from
Jul 9, 2021

Conversation

nemesis189
Copy link
Contributor

value for custom field was being fetched as undefined, fixed it by using this.get_value() method instead

@nemesis189 nemesis189 mentioned this pull request Jul 7, 2021
Merged
@coveralls
Copy link

Coverage Status

Coverage remained the same at 42.865% when pulling 6660a87 on nemesis189:fixed-POS-payment-custom-field-value into 0b320b5 on frappe:develop.

@nextchamp-saqib nextchamp-saqib changed the title fix: Fixed value fetching for custom field in POS Payment fix: value fetching for custom field in POS Jul 9, 2021
@nextchamp-saqib nextchamp-saqib merged commit 95a15ed into frappe:develop Jul 9, 2021
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@nemesis189
fix: value fetching for custom field in POS (frappe#26366)
587956a
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nextchamp-saqib nextchamp-saqib Awaiting requested review from nextchamp-saqib

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nemesis189 @coveralls @nextchamp-saqib