Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validation check for batch for stock reconciliation type in stock entry #26370

Merged
merged 3 commits into from Jul 14, 2021
Merged

fix: validation check for batch for stock reconciliation type in stock entry #26370

merged 3 commits into from Jul 14, 2021

Conversation

noahjacob
Copy link
Contributor

@noahjacob noahjacob commented Jul 7, 2021 •
edited

Issue:

  • There were no filters while selecting batch in stock reconciliation.
    image

  • The check for valid batch no. was skipped if Voucher_Type = "Stock Reconciliation".

Changes

  • Added Filters for batch no.
    image

  • Validation check for batch also validates if Voucher_type is "Stock Reconciliation"

@noahjacob noahjacob added the needs-tests This PR needs automated unit-tests. label Jul 7, 2021
@coveralls
Copy link

coveralls commented Jul 7, 2021 •
edited

Coverage Status

Coverage increased (+0.06%) to 42.989% when pulling 384c9a2 on noahjacob:stock_reco_batch_ux into ccb52f1 on frappe:develop.

@noahjacob noahjacob removed the needs-tests This PR needs automated unit-tests. label Jul 14, 2021
This was referenced Jul 14, 2021
Merged
Merged
@ankush ankush merged commit c932bae into frappe:develop Jul 14, 2021
This was referenced Jul 14, 2021
Closed
Closed
ankush pushed a commit that referenced this pull request Jul 14, 2021
@noahjacob
fix: validation check for batch for stock reconciliation type in stoc…
2c67894 
…k entry(bp #26370 ) (#26487)

* fix(ux): added filter for valid batch nos.

* fix: not validating batch no if entry type stock reconciliation

* test: validate batch_no
ankush pushed a commit that referenced this pull request Jul 14, 2021
@noahjacob
fix: validation check for batch for stock reconciliation type in stoc…
03f4db0 
…k entry(bp #26370 ) (#26488)

* fix(ux): added filter for valid batch nos.

* fix: not validating batch no if entry type stock reconciliation

* test: validate batch_no
@rohitwaghchaure rohitwaghchaure mentioned this pull request Jul 31, 2021
Merged
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@noahjacob
fix: validation check for batch for stock reconciliation type in stoc…
cc8ba23 
…k entry (frappe#26370)

* fix(ux): added filter for valid batch nos.

* fix: not validating batch no if entry type stock reconciliation

* test: validate batch_no
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankush ankush ankush approved these changes

@marination marination Awaiting requested review from marination

@rohitwaghchaure rohitwaghchaure Awaiting requested review from rohitwaghchaure rohitwaghchaure is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@noahjacob @coveralls @ankush