Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(tests): flaky SLA test and precision in Payment Entry test #26378

Merged
merged 3 commits into from
Jul 8, 2021

Conversation

ruchamahabal
Copy link
Member

@ruchamahabal ruchamahabal commented Jul 8, 2021

SLA test still failing randomly even after #26347

  • Enable set_only_once for document type field since all the custom / docfield creation happens only on the before_insert event
  • Recreate SLA for tests if it already exists

@coveralls
Copy link

coveralls commented Jul 8, 2021

Coverage Status

Coverage remained the same at 42.846% when pulling 88929b0 on ruchamahabal:fix-sla-test into 1823f31 on frappe:develop.

@ruchamahabal ruchamahabal marked this pull request as ready for review July 8, 2021 10:49
@ruchamahabal ruchamahabal changed the title fix: yet another fix for flaky SLA Test fix(tests): flaky SLA test and precision in Payment Entry test Jul 8, 2021
@ruchamahabal ruchamahabal merged commit d1cb8d0 into frappe:develop Jul 8, 2021
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
fix(tests): flaky SLA test and precision in Payment Entry test
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants