Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Validate LCV for Invoices without Update Stock #26400

Merged
merged 2 commits into from
Jul 9, 2021

Conversation

marination
Copy link
Collaborator

Issue:

  • While adding a Receipt Document in the Purchase Receipts table, a condition applied on the field is that if the document is a Purchase Invoice only suggest those that have Update Stock enabled.
  • However if you manually add one without Update Stock enabled, it allows to Save and Submit
  • Now if this Invoice has stock items in it, even though Update Stock is disabled, it creates SLEs for the line items to recalculate valuation
  • LCVs must be created against transactions that have stock impact only

Fix:
Screenshot 2021-07-05 at 2 23 21 PM

@marination marination merged commit 717826c into frappe:develop Jul 9, 2021
@coveralls
Copy link

Coverage Status

Coverage increased (+0.01%) to 42.87% when pulling 9817303 on marination:lcv-validate-invoice-develop into 6949114 on frappe:develop.

asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
…develop

fix: Validate LCV for Invoices without Update Stock
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants