Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Optionally allow rejected quality inspection on submission #26421

Merged
merged 4 commits into from
Jul 11, 2021

Conversation

marination
Copy link
Collaborator

Issue:

  • On creating a QI against a Purchase Receipt, it is possible that this QI is rejected.
  • In this case, the submission of the Purchase Receipt is blocked due to a rejected QI.
  • It could be possible that after rejection the rejected qty is updated in the Purchase Receipt and the user wants to submit it.

Solution:

  • Added Action If Quality Inspection Is Rejected in Stock Settings
    Screenshot 2021-06-21 at 4 23 28 PM
  • If it is set to Warn it will show a toast message on submission, if not it will block the submission
    qi-reject-warn
  • Cleaned up code to make it more readable

Docs: frappe/erpnext_documentation#365

- Use `get_single_value` instead of `get_doc` in validation
- Test Case to check impact of stock settings on SE with rejected qi
@coveralls
Copy link

Coverage Status

Coverage increased (+0.0002%) to 42.867% when pulling f67f13c on marination:qi-rejection-develop into 727e5d1 on frappe:develop.

@marination marination merged commit e39a7f2 into frappe:develop Jul 11, 2021
@marination
Copy link
Collaborator Author

@Mergifyio backport version-13-hotfix

@mergify
Copy link
Contributor

mergify bot commented Oct 11, 2021

Command backport version-13-hotfix: success

Backports have been created

@marination
Copy link
Collaborator Author

already ported to v13 via branch backport

asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
feat: Optionally allow rejected quality inspection on submission
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants