Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: create zero-dollar invoices for trial subscriptions #26441

Merged
merged 2 commits into from
Aug 25, 2021

Conversation

Alchez
Copy link
Contributor

@Alchez Alchez commented Jul 12, 2021

Any Subscriptions made with a trial period creates invoices with the full amount of the plan, when it should be free.

@stale
Copy link

stale bot commented Aug 10, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Aug 10, 2021
@ankush ankush removed the inactive label Aug 10, 2021
@stale
Copy link

stale bot commented Aug 25, 2021

This pull request has been automatically marked as stale because it has not had recent activity. It will be closed within a week if no further activity occurs, but it only takes a comment to keep a contribution alive :) Also, even if it is closed, you can always reopen the PR when you're ready. Thank you for contributing.

@stale stale bot added the inactive label Aug 25, 2021
@mergify
Copy link
Contributor

mergify bot commented Aug 25, 2021

@Stale[bot] is not allowed to run commands

Hey, I reacted but my real name is @Mergifyio

@stale stale bot removed the inactive label Aug 25, 2021
@nabinhait nabinhait merged commit 8730846 into frappe:develop Aug 25, 2021
asoral pushed a commit to asoral/erpnext that referenced this pull request Nov 12, 2021
@Alchez Alchez deleted the dev-subscription-trial branch March 2, 2022 11:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants