feat: Added dispatch address fields in Sales Ord, Sales Inv, Delivery Note for Eway Bill #26464
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…, Delivery Note for Eway Bill
nemesis189
requested review from
deepeshgarg007,
marination,
nextchamp-saqib and
rohitwaghchaure
as code owners
deepeshgarg007
requested changes
Jul 17, 2021
erpnext/regional/india/utils.py
Outdated
| data.fromStateCode = data.actualFromStateCode = validate_state_code( | ||
| company_address.gst_state_number, 'Company Address') | ||
| data.fromStateCode = validate_state_code(company_address.gst_state_number, 'Company Address') | ||
| data.actualFromStateCode = validate_state_code(dispatch_address.gst_state_number, 'Company Address') |
There was a problem hiding this comment.
Dispatch Address is not a mandatory field. This should only be called if dispatch address is set else actualFromStateCode will be same as company billing state
deepeshgarg007
approved these changes
Jul 21, 2021
nemesis189
removed request for
rohitwaghchaure,
ankush,
nextchamp-saqib and
marination
asoral
pushed a commit
to asoral/erpnext
that referenced
this pull request
Nov 12, 2021
…s-to-sales feat: Added dispatch address fields in Sales Ord, Sales Inv, Delivery Note for Eway Bill
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Dispatch Address field to specify from where the delivery is actually dispatched since it need not be same as the company address, modified the actualFromStatePin for Eway bill generation accordingly.
Sales order:
Delivery Note:
Sales Invoice:
no-docs